[GitHub] [hudi] c-f-cooper commented on a diff in pull request #8830: [MINOR] auto generate init client id

[via GitHub]

c-f-cooper commented on code in PR #8830:
URL: https://github.com/apache/hudi/pull/8830#discussion_r1213854825


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java:
##########
@@ -69,6 +70,12 @@ void testSetupClientId() throws Exception {
     }
   }
 
+  @Test
+  void testAutoGenerateClient() {
+      Configuration conf = getConf();
+      OptionsInference.setupClientId(conf);
+      assertNotNull(conf.getString(FlinkOptions.WRITE_CLIENT_ID), "auto 
generate client failed!");
+  }

Review Comment:
   > It should be a bug, the client still send heartbeat anyway for the 
INIT_CLIEN _ID:
   > 
   > 
https://github.com/apache/hudi/blob/00d50e91abe24aba31daa2fe2806de5414f03c77/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java#L179
   
   Maybe,bug if the INIT_CLIENT_ID is empty,all writer will shared the 
ckp_meta,the risk of concurrent modification will occupy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org