c-f-cooper commented on code in PR #8830: URL: https://github.com/apache/hudi/pull/8830#discussion_r1215209736
########## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/configuration/TestOptionsInference.java: ########## @@ -69,6 +70,12 @@ void testSetupClientId() throws Exception { } } + @Test + void testAutoGenerateClient() { + Configuration conf = getConf(); + OptionsInference.setupClientId(conf); + assertNotNull(conf.getString(FlinkOptions.WRITE_CLIENT_ID), "auto generate client failed!"); + } Review Comment: > Yeah, when a new client id is generated, the client would immediately sent a heart beat to the table, while other clients see the heartbeat, they skip the occupied hearbeated ids, can you help to check whether that works as expected? OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org