linfey90 commented on code in PR #8863:
URL: https://github.com/apache/hudi/pull/8863#discussion_r1214024916


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java:
##########
@@ -49,8 +48,7 @@ public static org.apache.hadoop.conf.Configuration 
getParquetConf(
    */
   public static org.apache.hadoop.conf.Configuration 
getHadoopConf(Configuration conf) {
     org.apache.hadoop.conf.Configuration hadoopConf = 
FlinkClientUtil.getHadoopConf();
-    Map<String, String> options = 
FlinkOptions.getPropertiesWithPrefix(conf.toMap(), HADOOP_PREFIX);
-    options.forEach(hadoopConf::set);
+    conf.toMap().forEach(hadoopConf::set);

Review Comment:
   Now the parameters that are passed are, for example 
fs.s3a.access.key,fs.s3a.secret.key,fs.s3a.endpoint,fs.s3a.impl.disable.cache,fs.s3a.impl,fs.s3a.connection.maximum.These
 parameters can be used directly to the underlying file system.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to