linfey90 commented on code in PR #8863:
URL: https://github.com/apache/hudi/pull/8863#discussion_r1218962022
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java:
##########
@@ -49,8 +48,7 @@ public static org.apache.hadoop.conf.Configuration
getParquetConf(
*/
public static org.apache.hadoop.conf.Configuration
getHadoopConf(Configuration conf) {
org.apache.hadoop.conf.Configuration hadoopConf =
FlinkClientUtil.getHadoopConf();
- Map<String, String> options =
FlinkOptions.getPropertiesWithPrefix(conf.toMap(), HADOOP_PREFIX);
- options.forEach(hadoopConf::set);
+ conf.toMap().forEach(hadoopConf::set);
Review Comment:
Useless, because we will call HadoopConfigurations. getHadoopConf (conf)
filter out k1. It is closer to the underlying file system interface than the
Flink option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
