hudi-agent commented on code in PR #19330:
URL: https://github.com/apache/hudi/pull/19330#discussion_r3624628080
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -97,6 +97,11 @@
<include>org.jetbrains.kotlin:*</include>
<include>org.rocksdb:rocksdbjni</include>
<include>org.antlr:stringtemplate</include>
+ <!-- ANTLR runtime needed by Hive DDL parsing
(Driver.compile); hive-exec
+ does not embed it. Only bundled when a shade-hive
profile is active. -->
+ <include>org.antlr:antlr-runtime</include>
Review Comment:
🤖 These three ANTLR artifacts are added to the shared artifactSet and,
unlike the embedded deps below, are bundled un-relocated (org.antlr.** stays
as-is). Is that intentional? Two things worth confirming: (1) the includes
aren't scoped to the shade-hive profiles, so if any default-bundle dependency
transitively resolves antlr-runtime/ST4/antlr4-runtime they'd get pulled into
the default bundle too; and (2) under Flink child-first loading, shipping an
un-shaded org.antlr.runtime/org.antlr.v4.runtime could shadow (or be shadowed
by) a different ANTLR version already on the runtime classpath. Have you
checked there's no such collision?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -240,6 +327,15 @@
<exclude>**/*.proto</exclude>
</excludes>
</filter>
+ <!-- hive-exec embeds a stale Avro 1.7.7 (no LogicalType);
strip it so the
Review Comment:
🤖 nit: the `1.7.7` version pin in this comment will silently go stale if the
hive-exec's bundled Avro version ever changes — could you drop it and just say
"stale embedded Avro (no LogicalType support)"? The key diagnostic is the
missing LogicalType, not the specific version.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
