skywalker0618 commented on code in PR #19330:
URL: https://github.com/apache/hudi/pull/19330#discussion_r3626392562
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -97,6 +97,11 @@
<include>org.jetbrains.kotlin:*</include>
<include>org.rocksdb:rocksdbjni</include>
<include>org.antlr:stringtemplate</include>
+ <!-- ANTLR runtime needed by Hive DDL parsing
(Driver.compile); hive-exec
+ does not embed it. Only bundled when a shade-hive
profile is active. -->
+ <include>org.antlr:antlr-runtime</include>
Review Comment:
(1) Scoped to shade-hive profiles. (2) I've tested hive-sync tool on a flink
job to ensure it's working
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -240,6 +327,15 @@
<exclude>**/*.proto</exclude>
</excludes>
</filter>
+ <!-- hive-exec embeds a stale Avro 1.7.7 (no LogicalType);
strip it so the
Review Comment:
Changed the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
