skywalker0618 commented on code in PR #19330:
URL: https://github.com/apache/hudi/pull/19330#discussion_r3626385859
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -228,6 +233,88 @@
<pattern>com.uber.m3.</pattern>
<shadedPattern>org.apache.hudi.com.uber.m3.</shadedPattern>
</relocation>
+
+ <!-- hive-exec is a fat jar that embeds these deps
un-relocated; under Flink
+ child-first classloading they shadow the versions
Hudi/Flink need. No-op
+ for the default bundle (classes only present when a
shade-hive profile
Review Comment:
Thanks for the comments! Applied changes only in flink-bundle-shade-hive*
profiles and verified Parquet ABI doesn't change before vs. after my change:
Parquet classes in BASE (pre-change) default bundle : 1755
Parquet classes in HEAD (with shade change) default : 1755
=== CRC-32 diff of all org/apache/parquet/**.class (empty = byte-identical
ABI) ===
IDENTICAL: 0 differences across 1755 Parquet classes — default bundle
Parquet ABI UNCHANGED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
