voonhous commented on code in PR #19642:
URL: https://github.com/apache/hudi/pull/19642#discussion_r3793863735
##########
pom.xml:
##########
@@ -131,7 +131,13 @@
<hive.parquet.version>1.10.1</hive.parquet.version>
<hive.avro.version>1.11.4</hive.avro.version>
<presto.version>0.273</presto.version>
- <trino.version>481</trino.version>
+ <!-- trino.sha is the exact trinodb/trino commit hudi-trino builds
against; its project
+ version must equal trino.version and the two advance only together.
trino.e2e.version is
+ the latest released Trino (e2e server image, trino-jdbc for the integ
tests). Keep each
+ property on one line: the workflows and
scripts/trino/bootstrap_trino.sh read them with sed. -->
+ <trino.version>484-SNAPSHOT</trino.version>
Review Comment:
The alternatives and the why are in #19640: periodic pin-to-pin upgrades
produce multi-release big-bang migrations (this PR started life as a 472->483
one), and a thin SPI-compat shim cannot absorb `trino-hive`-internal churn,
which moves faster than the SPI itself. Ownership/cadence is now documented in
the pom comment and module README (00c42eebfa51): the nightly job proposes the
pin, committers merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
