voonhous commented on code in PR #19642:
URL: https://github.com/apache/hudi/pull/19642#discussion_r3793864545
##########
pom.xml:
##########
@@ -131,7 +131,13 @@
<hive.parquet.version>1.10.1</hive.parquet.version>
<hive.avro.version>1.11.4</hive.avro.version>
<presto.version>0.273</presto.version>
- <trino.version>481</trino.version>
+ <!-- trino.sha is the exact trinodb/trino commit hudi-trino builds
against; its project
+ version must equal trino.version and the two advance only together.
trino.e2e.version is
+ the latest released Trino (e2e server image, trino-jdbc for the integ
tests). Keep each
+ property on one line: the workflows and
scripts/trino/bootstrap_trino.sh read them with sed. -->
+ <trino.version>484-SNAPSHOT</trino.version>
+ <trino.sha>5b82ec9e7116ec1ed3a83f4cc2f8cf9aaa87b12f</trino.sha>
Review Comment:
Yes -- exactly because SNAPSHOT coordinates do not change when the pin does,
`bootstrap_trino.sh` deletes `~/.m2/repository/io/trino` before installing
(`--keep-m2` is the explicit opt-out), and CI does the same purge before
restoring its per-`trino.sha` cache. The README tells contributors to re-run
the script per pin advance, and the script cross-checks the checkout's version
via `help:evaluate` so a mismatched pin fails loudly.
##########
pom.xml:
##########
@@ -131,7 +131,13 @@
<hive.parquet.version>1.10.1</hive.parquet.version>
<hive.avro.version>1.11.4</hive.avro.version>
<presto.version>0.273</presto.version>
- <trino.version>481</trino.version>
+ <!-- trino.sha is the exact trinodb/trino commit hudi-trino builds
against; its project
+ version must equal trino.version and the two advance only together.
trino.e2e.version is
+ the latest released Trino (e2e server image, trino-jdbc for the integ
tests). Keep each
+ property on one line: the workflows and
scripts/trino/bootstrap_trino.sh read them with sed. -->
+ <trino.version>484-SNAPSHOT</trino.version>
+ <trino.sha>5b82ec9e7116ec1ed3a83f4cc2f8cf9aaa87b12f</trino.sha>
+ <trino.e2e.version>483</trino.e2e.version>
Review Comment:
Trino releases every 4-7 weeks and most cycles touch the SPI, so a window
can plausibly last weeks. While e2e is paused, every PR is still gated by
compile, the unit suites (incl. the MOR read and dynamic-filtering tests) and
javadoc, and every release runs e2e at zero drift after the pin-back. If
windows prove mostly-open, the documented fallback is a weekly source-built
server image (#19640).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
