SEPURI-SAI-KRISHNA commented on code in PR #19648:
URL: https://github.com/apache/hudi/pull/19648#discussion_r3815142276
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/PartitionPathFormatterBase.java:
##########
@@ -75,15 +75,11 @@ public final S combine(List<String> partitionPathFields,
Object... partitionPath
if (useHiveStylePartitioning) {
Review Comment:
You are right, and the comment is corrected, the "unreachable" claim is
gone. It now says the combination is documented as mutually exclusive but only
enforced by HoodieCatalogTable#extraTableConfig on the SQL options, so df.write
and HoodieStreamer still accept it, and records why the formatter does not
mirror the Avro path (doParsePartitionColumnValues cannot read that layout
back). Test kept with the corrected comment.
One supporting detail for the all-write-paths check: the config
documentation of SLASH_SEPARATED_DATE_PARTITIONING already ends with "Cannot be
used together with hive-style partitioning", so adding the check to
HoodieWriterUtils.validateTableConfig honors a documented contract rather than
adding a restriction. Filed as #19669.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
