SEPURI-SAI-KRISHNA commented on code in PR #19648:
URL: https://github.com/apache/hudi/pull/19648#discussion_r3815137650
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/PartitionPathFormatterBase.java:
##########
@@ -75,15 +75,11 @@ public final S combine(List<String> partitionPathFields,
Object... partitionPath
if (useHiveStylePartitioning) {
sb.appendJava(partitionPathFields.get(i))
- .appendJava("=")
- .append(partitionPathPartStr);
- } else if (slashSeparatedDatePartitioning) {
- String res = ((String) partitionPathPartStr).replace('-', '/');
- sb.append(((S) res));
- } else {
- sb.append(partitionPathPartStr);
+ .appendJava("=");
}
+ sb.append(partitionPathPartStr);
Review Comment:
Agreed on both points.
The PR description no longer claims a write-path behavior change: the
multi-field branch lands in file-index prefix pruning
(SparkHoodieTableFileIndex#composeRelativePartitionPath) and in bucket routing
via RowRecordKeyExtractor, not in any path that names a directory, and no
existing table layout changes.
For the validation I have filed #19666 rather than widening this PR -- it
covers rejecting slash-separated date partitioning with more than one partition
field at table creation and in writer config validation.
ShowHoodieTablePartitionsCommand.scala:60-61 already checkStates that same
invariant, so one path treats single-field as a hard requirement while table
creation accepts any number of fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
