hudi-agent commented on code in PR #19710:
URL: https://github.com/apache/hudi/pull/19710#discussion_r3835445189
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SlashEncodedDayPartitionValueExtractor.java:
##########
@@ -65,4 +73,11 @@ public List<String> extractPartitionValuesInPath(String
partitionPath) {
return Collections.singletonList(dateTime.format(getDtfOut()));
Review Comment:
🤖 nit: `isDefaultPartition` is identical in both extractor classes — could
you move it to a shared base class or a small static helper in e.g.
`PartitionPathEncodeUtils` so the two implementations stay in sync
automatically?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
