SEPURI-SAI-KRISHNA commented on code in PR #19710:
URL: https://github.com/apache/hudi/pull/19710#discussion_r3835988750
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SlashEncodedDayPartitionValueExtractor.java:
##########
@@ -65,4 +73,11 @@ public List<String> extractPartitionValuesInPath(String
partitionPath) {
return Collections.singletonList(dateTime.format(getDtfOut()));
}
+
+ private static boolean isDefaultPartition(String partitionPath) {
Review Comment:
Applied — extracted to
`PartitionPathEncodeUtils#isDefaultPartitionValue(String)` and used by both
extractors, so the duplicated private copies are gone. It also handles the
deprecated `default` marker per your other comment, so both concerns are fixed
together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
