hudi-agent commented on code in PR #19710:
URL: https://github.com/apache/hudi/pull/19710#discussion_r3846192354
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SlashEncodedDayPartitionValueExtractor.java:
##########
@@ -52,6 +55,13 @@ private DateTimeFormatter getDtfOut() {
@Override
public List<String> extractPartitionValuesInPath(String partitionPath) {
+ // NOTE: A null or empty partition value lands in the default-partition
directory, which is a
Review Comment:
🤖 nit: this NOTE block restates what's already covered by
`isDefaultPartitionValue`'s Javadoc, and the same text is copy-pasted nearly
verbatim into the hour extractor. Could you trim both to a short line like `//
default-partition directory — pass straight through` and let the utility's
Javadoc be the authoritative explanation?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
