hudi-agent commented on code in PR #20028:
URL: https://github.com/apache/hudi/pull/20028#discussion_r4129943315
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -653,50 +850,89 @@ protected synchronized boolean renewLock() {
Option.of(getLock()));
switch (currentLock.getLeft()) {
case ACQUIRED_BY_OTHERS:
+ if (afterRetriableAttempt) {
Review Comment:
🤖 The ownership check in `earlierRenewalWriteLanded` looks sound on its own,
since only this provider ever writes its UUID `ownerId`. Could we drop the
`afterRetriableAttempt` gate? With `RENEW_MAX_RETRIES = 1`, a 500 that landed
followed by another 5xx on the retry means the next cycle's first attempt gets
a 412 without a reconcile, and the heartbeat stops even though we still hold
the lease.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
