linliu-code commented on PR #20028: URL: https://github.com/apache/hudi/pull/20028#issuecomment-6004619929
Scope update: I've dropped the renewal reconcile (the read-back that adopted a renewal which landed behind a 5xx) from this PR. The fix now covers lock release only. Renewal behaves as it did before this PR: if a renewal lands behind an ambiguous answer, the next renewal's precondition fails and the lock is treated as lost. That fails safe. Kept from that commit: the try/catch around the release-path read-back (with testUnlockClearsLocalLockWhenReconcileReadThrows) and the corrected "will retry after backoff" log messages. The RFC update in #20186 is scoped to acquire and release to match. My earlier reply on the renewal-gate thread therefore no longer applies to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
