ashokraminedi commented on code in PR #20193:
URL: https://github.com/apache/hudi/pull/20193#discussion_r4214165632
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/schema/TestVariantShreddingMixedLayouts.scala:
##########
@@ -2321,6 +2319,31 @@ class TestVariantShreddingMixedLayouts extends
HoodieSparkSqlTestBase with Varia
}
}
+ test("Variant read does not mutate the session vectorized reader
configuration") {
+ assume(HoodieSparkUtils.gteqSpark4_1, SPARK_4_1_GATE)
+
+ withVariantTable(
+ "vectorized reader session conf",
+ "cow",
+ recordTypes = Seq(HoodieRecordType.SPARK)) { (tableName, _, _) =>
+
+ spark.sql(
+ s"""insert into $tableName values (1, parse_json('{"key":"v1"}'),
1000)""")
+
+ withSQLConf("spark.sql.parquet.enableVectorizedReader" -> "true") {
+ assert(spark.conf.get("spark.sql.parquet.enableVectorizedReader") ==
"true")
Review Comment:
Agreed, removed the redundant pre-read assertion. The post-read assertion
remains to catch the regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
