voonhous commented on PR #20193: URL: https://github.com/apache/hudi/pull/20193#issuecomment-6120862310
#20183 now carries both regression tests from this PR (f08c644c38, credited in the commit message) and also removes the `spark.sql.parquet.enableVectorizedReader` write, so this PR is fully covered once #20183 merges. On the `count(*)` pin: #20183 fixes the count(*) failure tracked in #20139 (empty projections skip the schema-on-read merge, and `HoodieVectorizedParquetRecordReader.close()` no longer NPEs), so it keeps the pin on the default vectorized path instead of forcing `enableVectorizedReader=false`. Could we close this as superseded once #20183 lands? The `HoodieBaseRelation.imbueConfigs` leak (filterPushdown / recordLevelFilter) from the earlier review is not touched by either PR, so that one is still open for a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
