voonhous commented on PR #20193: URL: https://github.com/apache/hudi/pull/20193#issuecomment-6121242590
On the `HoodieBaseRelation.imbueConfigs` leak mentioned above: we are leaving it out of #20183. It lives on the older relation path (`BaseFileOnlyRelation`, `MergeOnReadSnapshotRelation`, the incremental relations), not in `HoodieFileGroupReaderBasedFileFormat`, and it only forces `spark.sql.parquet.filterPushdown` / `spark.sql.parquet.recordLevelFilter.enabled` to `true`, so results stay correct. Removing it is not a plain delete either: those relations read the flags from the session conf, so the fix has to pass them through the reader options instead. It will be picked up by the next PR that touches `HoodieBaseRelation`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
