wombatu-kun commented on code in PR #20544:
URL: https://github.com/apache/hudi/pull/20544#discussion_r4520727214


##########
hudi-common/src/main/java/org/apache/hudi/common/avro/AvroRecordContext.java:
##########
@@ -107,6 +118,36 @@ public Object getValue(IndexedRecord record, HoodieSchema 
schema, String fieldNa
     return getFieldValueFromIndexedRecord(record, fieldName);
   }
 
+  @Override
+  public Comparable getOrderingValue(IndexedRecord record, HoodieSchema 
schema, List<String> orderingFieldNames) {

Review Comment:
   `AvroOrderingValueConverter.convertFieldValue` returns any value equal to 
`OrderingValues.getDefault()` unchanged, so in a multi-field ordering a 
1970-01-01 DATE component written as `Integer 0` by `HoodieFlinkRecord` or 
`HoodieSparkRecord` is never converted, and `ArrayComparable.compareTo` still 
throws against the data side's `LocalDate`. Is that acceptable until the 
null-ordering follow-up, or should DATE components convert `0` as a real date?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to