cshuo commented on code in PR #20544:
URL: https://github.com/apache/hudi/pull/20544#discussion_r4522104053


##########
hudi-common/src/main/java/org/apache/hudi/common/avro/AvroRecordContext.java:
##########
@@ -107,6 +118,36 @@ public Object getValue(IndexedRecord record, HoodieSchema 
schema, String fieldNa
     return getFieldValueFromIndexedRecord(record, fieldName);
   }
 
+  @Override
+  public Comparable getOrderingValue(IndexedRecord record, HoodieSchema 
schema, List<String> orderingFieldNames) {

Review Comment:
   Null ordering values being replaced with Integer(0) are already tracked in 
[apache/hudi#19636](https://github.com/apache/hudi/issues/19636) and 
[apache/hudi#19637](https://github.com/apache/hudi/pull/19637). This PR 
intentionally preserves the existing null/default semantics and leaves that 
change to the follow-up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to