cshuo commented on code in PR #20544:
URL: https://github.com/apache/hudi/pull/20544#discussion_r4533443579
##########
hudi-common/src/main/java/org/apache/hudi/common/avro/HoodieAvroUtils.java:
##########
@@ -866,6 +866,11 @@ public static Object
convertValueForSpecificDataTypes(Schema fieldSchema,
* encoding for these logical types is fixed by spec to int / long and is
identical across Avro
* versions; only the in-memory Java type returned by the reader changed.
*
+ * <p>Also accepts decoded delete-wrapper values: {@link Date}, {@link
Timestamp}, and
Review Comment:
The delete-wrapper encoding/decoding remains unchanged. This change only
lets convertValueForAvroLogicalTypes accept the already-decoded Java ordering
values for delete record.
The intent is to reuse the same logical-type normalization for data and
delete ordering values, rather than maintain two implementations that could
diverge. The helper already serves ordering extraction through
getNestedFieldVal, in addition to other callers.
Would moving the handling of decoded delete values into
AvroOrderingValueConverter address your concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]