vaibhav-sinha commented on a change in pull request #2923:
URL: https://github.com/apache/hudi/pull/2923#discussion_r642208206
##########
File path:
hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java
##########
@@ -380,12 +380,12 @@ public void testUpsertWithDelete() throws Exception {
@Test
public void testInsertWithMiniBatches() throws Exception {
// reset the config option
- conf.setDouble(FlinkOptions.WRITE_BATCH_SIZE, 0.0006); // 630 bytes batch
size
+ conf.setDouble(FlinkOptions.WRITE_BATCH_SIZE, 0.00075); // 786 bytes batch
size
Review comment:
Yes. I ran the tests from the master branch on my local and they seem to
fail for these as well. What I could figure figure out was the size estimate of
the HoodieRecord calculated by HoodieRecordSizeEstimator was higher from what
was being assumed in the testcase. Hence the batch size was being set to a
lower value in the testcase causing the flush to happen earlier than expected.
I have modified the batch size based on the output of
HoodieRecordSizeEstimator. Not sure if this is the right fix though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
