vaibhav-sinha commented on a change in pull request #2923:
URL: https://github.com/apache/hudi/pull/2923#discussion_r647082023
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/utils/PayloadCreation.java
##########
@@ -76,6 +78,9 @@ public static PayloadCreation instance(Configuration conf)
throws Exception {
ValidationUtils.checkState(preCombineField != null);
Comparable<?> orderingVal = (Comparable<?>)
HoodieAvroUtils.getNestedFieldVal(record,
preCombineField, false);
+ if(orderingVal instanceof LocalDateTime) {
+ orderingVal = ((LocalDateTime)
orderingVal).atZone(ZoneId.systemDefault()).toInstant().toEpochMilli();
Review comment:
The data types returned from `HoodieAvroUtils.getNestedFieldVal` can be
any valid Avro types including string, int, decimal, uuid, etc. How do you to
check for timezone in these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
