numinnex commented on code in PR #2032:
URL: https://github.com/apache/iggy/pull/2032#discussion_r2241593909
##########
core/server/src/shard/system/partitions.rs:
##########
@@ -73,6 +74,58 @@ impl IggyShard {
partition_ids
};
+ {
Review Comment:
This does not belong in this function, if you look at the `TCP`
implementation, those events are broadcasted at the `handler` level, you have
to do the same with HTTP, otherwise when handling TCP requests, we will
broadcast those events twice.
Same for other places that you've changed in the `shard/system` modules.
##########
core/server/src/tcp/tcp_socket.rs:
##########
@@ -58,7 +58,7 @@ pub fn build(ipv6: bool, config: &TcpSocketConfig) -> Socket {
.set_keepalive(config.keepalive)
.expect("Unable to set SO_KEEPALIVE on socket");
socket
- .set_nodelay(config.nodelay)
+ .set_tcp_nodelay(config.nodelay)
Review Comment:
Those got changed after updating `compio` version, make sure that you've
rebased your branch with latest changes, unless you had to downgrade the
version of `compio` in order to get it to work with the `cyper` fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
