numinnex commented on code in PR #2032:
URL: https://github.com/apache/iggy/pull/2032#discussion_r2242032278
##########
core/server/src/tcp/tcp_socket.rs:
##########
@@ -58,7 +58,7 @@ pub fn build(ipv6: bool, config: &TcpSocketConfig) -> Socket {
.set_keepalive(config.keepalive)
.expect("Unable to set SO_KEEPALIVE on socket");
socket
- .set_nodelay(config.nodelay)
+ .set_tcp_nodelay(config.nodelay)
Review Comment:
In fact I've checked the `tcp_socket` file and it's not used at all and
won't be used in the future, since we have replaced it with the
`bind_with_options` method from `compio` that I've contributed. We can ignore
that completely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
