numinnex commented on code in PR #2032:
URL: https://github.com/apache/iggy/pull/2032#discussion_r2242022706


##########
core/server/src/tcp/tcp_socket.rs:
##########
@@ -58,7 +58,7 @@ pub fn build(ipv6: bool, config: &TcpSocketConfig) -> Socket {
             .set_keepalive(config.keepalive)
             .expect("Unable to set SO_KEEPALIVE on socket");
         socket
-            .set_nodelay(config.nodelay)
+            .set_tcp_nodelay(config.nodelay)

Review Comment:
   But since you've forked the `cyper` repo and replaced the `compio` 
dependency in there to use the same version from commit hash that we use on the 
server, why it can't use the same `TcpListener` that we are currently using  
for the TCP implementation ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to