krishvishal commented on code in PR #2032:
URL: https://github.com/apache/iggy/pull/2032#discussion_r2241868942
##########
core/server/src/tcp/tcp_socket.rs:
##########
@@ -58,7 +58,7 @@ pub fn build(ipv6: bool, config: &TcpSocketConfig) -> Socket {
.set_keepalive(config.keepalive)
.expect("Unable to set SO_KEEPALIVE on socket");
socket
- .set_nodelay(config.nodelay)
+ .set_tcp_nodelay(config.nodelay)
Review Comment:
I've to use `compio-net` for using compio's `TcpListener`, which requires
`socket2=0.6.0` and that version of `socket2` only has `set_tcp_delay` and
other things I've changed.
You can see that `compio` itself depends on `socket2=0.6.0`:
https://github.com/compio-rs/compio/blob/master/Cargo.toml#L60
I've rebased my branch with latest `io_uring_tcp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
