yesamer commented on code in PR #2197:
URL:
https://github.com/apache/incubator-kie-kogito-examples/pull/2197#discussion_r3086488502
##########
pom.xml:
##########
@@ -386,6 +388,14 @@
<outputTimestamp>${project.build.outputTimestamp}</outputTimestamp>
</configuration>
</plugin>
+ <plugin>
+ <!-- So, how to consider kogito-examples ? Shall we manage as the
upstream code, enforcing rules, or as templates for final users, where such
rules may not make sense ? -->
Review Comment:
@gitgabrio In my opinion, the current proposal makes sense. We should
enforce this rule only within our stack; the leaf POM in the end user project
should not inherit it. I think the comment can be removed.
##########
kogito-quarkus-examples/process-instance-migration-quarkus/pom.xml:
##########
@@ -36,8 +36,8 @@
<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
<quarkus.platform.version>3.27.2</quarkus.platform.version>
<kogito.bom.group-id>org.kie.kogito</kogito.bom.group-id>
- <kogito.bom.artifact-id>kogito-bom</kogito.bom.artifact-id>
- <kogito-apps.bom.artifact-id>kogito-apps-bom</kogito-apps.bom.artifact-id>
+ <kogito.bom.artifact-id>kogito-quarkus-bom</kogito.bom.artifact-id>
Review Comment:
@gitgabrio
- Shouldn't this be propagated to all Quarkus based examples? Why 2 examples
only?
- Isn't the quarkus BOM already imported by kogito-quarkus-bom?
##########
kogito-springboot-examples/pom.xml:
##########
@@ -36,18 +36,9 @@
<properties>
<java.module.name>org.kie.kogito.examples.springboot</java.module.name>
+ <version.org.springframework.boot>3.5.10</version.org.springframework.boot>
Review Comment:
@gitgabrio Why this example only requires it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
