martinweiler commented on code in PR #2197:
URL:
https://github.com/apache/incubator-kie-kogito-examples/pull/2197#discussion_r3275618163
##########
kogito-springboot-examples/pom.xml:
##########
@@ -35,77 +35,23 @@
<name>Kogito Example :: Spring Boot</name>
<properties>
+ <!-- Used to define which poms are allowed to have dependencyManagement
sections. This is to enforce the convention that only the root pom should have
dependencyManagement, and all other poms should inherit from it. -->
+
<allowedPomsList>org.kie.kogito.examples:kogito-springboot-examples</allowedPomsList>
<java.module.name>org.kie.kogito.examples.springboot</java.module.name>
- <!-- Override Netty to 4.2.x for these SB examples. The shared
kogito-dependencies-bom pins 4.1.x
- for Quarkus/Vert.x, but Infinispan 15.x's Hot Rod client needs 4.2
(uses io.netty.channel.IoHandle).
- Per-artifact pins below are required because BOM-imported entries
cannot override the parent-
- imported BOM's explicit versions. Mirrors the matching block in
kogito-runtimes' springboot/pom.xml.
- TODO drop after the planned BOM split. -->
+ <!-- TODO: remove the following properties and declare
kogito-apps-springboot-bom as parent, to have everything already inherited-->
Review Comment:
Why is this `TODO` still in here? Isn't `kogito-apps-springboot-bom`
imported further down in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
