zheng-da commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156219864
##########
File path: include/mxnet/ndarray.h
##########
@@ -608,6 +549,37 @@ class NDArray {
<< "CheckAndAllocAuxData is not intended for kDefaultStorage";
ptr_->CheckAndAllocAuxData(i, aux_shape);
}
+
+#if MXNET_USE_MKLDNN == 1
+ /*
+ * This function returns mkldnn::memory with the default primitive_desc.
+ */
+ std::shared_ptr<const mkldnn::memory> GetMKLDNNData() const;
+ /*
+ * This function returns mkldnn::memory with the given primitive_desc
+ * as long as the array size meets the required size in the given
primitive_desc.
+ */
+ std::shared_ptr<const mkldnn::memory> GetMKLDNNData(
+ const mkldnn::memory::primitive_desc &desc) const;
+ /*
+ * This function returns mkldnn::memory with the given primitive_desc.
+ * The returned mkldnn::memory will have the same physical layout as
+ * the given primitive_desc.
+ */
+ std::shared_ptr<const mkldnn::memory> GetMKLDNNDataReorder(
+ const mkldnn::memory::primitive_desc &desc) const;
+
+ void CopyFrom(const mkldnn::memory &mem);
+ std::shared_ptr<mkldnn::memory> CreateMKLDNNData(
+ const mkldnn::memory::primitive_desc &desc);
+
+ /*
+ * This function is used inside operators to reshape an array.
+ * It's used by FullyConnected right now.
Review comment:
FullyConnected needs to reshape an array to 2D. The current implementation
of Reshape for MKLDNN hangs if I call it inside an operator, because I call
WaitToRead() in the end. Could you help me check if the implementation of
Reshape is correct/necessary?
https://github.com/zheng-da/incubator-mxnet/blob/refactor/src/ndarray/ndarray.cc#L282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
