zheng-da commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156240271
##########
File path: python/mxnet/ndarray/sparse.py
##########
@@ -1138,6 +1139,8 @@ def _ndarray_cls(handle, writable=True,
stype=_STORAGE_TYPE_UNDEFINED):
stype = _storage_type(handle)
if stype == _STORAGE_TYPE_DEFAULT:
return NDArray(handle, writable=writable)
+ elif stype == _STORAGE_TYPE_MKLDNN:
+ return NDArray(handle, writable=writable)
Review comment:
right. i wanted to delete MKLNDArray since we don't want to expose MKLDNN to
users. But we still want users to specify MKLDNN storage during the inference,
so I kept the code as it was. We need to discuss how we allow users to specify
MKLDNN storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
