zheng-da commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156508822
##########
File path: src/ndarray/ndarray.cc
##########
@@ -95,12 +319,36 @@ NDArray NDArray::ReshapeWithRecord(const TShape &shape) {
return ret;
}
-
NDArray NDArray::Slice(index_t begin, index_t end) const {
CHECK(!is_none()) << "NDArray is empty";
CHECK_LE(begin, end)
<< "Invalid slicing range [" << begin << ", " << end << ")";
CHECK_GE(shape_[0], end) << "Slice end index out of range";
+#if MXNET_USE_MKLDNN == 1
+ CHECK(storage_type() == kDefaultStorage || storage_type() == kMKLDNNStorage);
Review comment:
Slice doesn't work on sparse arrays.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
