zheng-da commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156240694
##########
File path: src/common/utils.h
##########
@@ -327,17 +349,7 @@ inline std::string dispatch_mode_string(const
DispatchMode x) {
/*! \brief get string representation of storage_type */
-inline std::string stype_string(const int x) {
- switch (x) {
- case kDefaultStorage:
- return "default";
- case kCSRStorage:
- return "csr";
- case kRowSparseStorage:
- return "row_sparse";
- }
- return "unknown";
-}
+std::string stype_string(const int x);
Review comment:
there isn't a big reason for this. I didn't want to compile everything
whenever I change a header file, so I moved the definition of the function in
the .cc file. I'll move the code back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
