KellenSunderland commented on a change in pull request #12530: Implement mkldnn
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221862468
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -178,19 +226,20 @@ Graph QuantizeGraph(Graph &&src) {
// If the new_node op registered attr FNeedRequantize, insert requantize
node after it.
// Here it's assumed that the quantized_op node only produces three
outputs:
// out_data, min_range, and max_range.
- if (need_requantize_map.count(new_node->op()) > 0
- && need_requantize_map[new_node->op()](new_node->attrs)) {
+ if (need_requantize_map.count(new_node->op()) > 0 &&
+ need_requantize_map[new_node->op()](new_node->attrs)) {
NodePtr requantize_node = Node::Create();
requantize_node->attrs.op = Op::Get("_contrib_requantize");
requantize_node->attrs.name = "requantize_" + node->attrs.name;
if (requantize_node->op()->attr_parser != nullptr) {
requantize_node->op()->attr_parser(&(requantize_node->attrs));
}
for (size_t i = 0; i < 3; ++i) {
- requantize_node->inputs.emplace_back(NodeEntry{new_node,
static_cast<uint32_t>(i), 0});
+ requantize_node->inputs.emplace_back(
+ NodeEntry{new_node, static_cast<uint32_t>(i), 0});
}
new_node = requantize_node;
- }
+ }
Review comment:
Nit: whitespace seems off here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
