KellenSunderland commented on a change in pull request #12530: Implement mkldnn
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r221866332
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -89,17 +89,42 @@ std::vector<NodeEntry>
OfflineParams(std::vector<NodeEntry>&& outputs,
return outputs;
}
-inline bool NeedQuantize(NodePtr node, const std::unordered_set<NodePtr>
excluded_nodes) {
+inline bool NeedQuantize(NodePtr node, const std::unordered_set<std::string>&
excluded_nodes) {
static auto& quantized_op_map =
Op::GetAttr<mxnet::FQuantizedOp>("FQuantizedOp");
- return quantized_op_map.count(node->op()) && !excluded_nodes.count(node);
+ static auto& fexec_type = nnvm::Op::GetAttr<FExecType>("FExecType");
+ const auto& op = node->op();
+ if (op && quantized_op_map.count(op)) {
+ bool need = true;
+ if (excluded_nodes.count(node->attrs.name)) {
+ need = false;
+ } else if (node->attrs.subgraphs.size()) {
Review comment:
Nit: consider
```
else if (!node->attrs.subgraphs.empty())
```
A little more explicit / readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
