KellenSunderland commented on a change in pull request #12530: Implement mkldnn
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222577892
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -53,6 +53,7 @@ def _quantize_params(qsym, params):
qsym : Symbol
Quantized symbol from FP32 symbol.
params : dict of str->NDArray
+ th_dict: dict of min/max pairs of layers' output
Review comment:
I may be misunderstanding something here, but Is the thresholding applied to
the output? My understanding was it's usually applied to the weights during
quantization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
