KellenSunderland commented on a change in pull request #12530: Implement mkldnn
convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222580648
##########
File path: src/ndarray/ndarray.cc
##########
@@ -1592,8 +1601,12 @@ void NDArray::Save(dmlc::Stream *strm) const {
save_data = nd_cpu.data();
} else {
this->WaitToRead();
- save_data = this->data();
nd_cpu = *this;
+#if MXNET_USE_MKLDNN == 1
+ if (nd_cpu.IsMKLDNNData())
Review comment:
NIt: I believe the project encourages braces even on single line
conditionals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
