[
https://issues.apache.org/jira/browse/MINIFI-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522776#comment-16522776
]
ASF GitHub Bot commented on MINIFI-441:
---------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/130
MINIFI-441 Update Docker configuration and documentation
MINIFI-441 Update versions to reflect next release.
Adding tailing of the minifi process in the Dockerfile and updating
documentation on how to make use of the Docker image.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under minifi-assembly?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi MINIFI-441
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit f272355ce1924f6d7befda4b83437f1a9b1a71e7
Author: Aldrin Piri <aldrin@...>
Date: 2018-06-25T18:36:35Z
MINIFI-441 Update versions to reflect next release.
Adding tailing of the minifi process in the Dockerfile and updating
documentation on how to make use of the Docker image.
----
> Update Dockerfile to '0.4.0' and better align with practices set in NiFi
> ------------------------------------------------------------------------
>
> Key: MINIFI-441
> URL: https://issues.apache.org/jira/browse/MINIFI-441
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.5.0
>
>
> The DockerHub Dockerfile[1] still lists 0.2.0 (even though dockerhub is up to
> 0.4.0[2]). Also, it doesn't appear to follow best practices like the NiFi
> Dockerfile[3] does, such as tailing the log file for exposing to the docker
> log.
> Lastly, there doesn't appear to be any documentation on the expected way to
> pass the bootstrap.conf and config.yml files. I'm assuming that this is done
> by creating a volume at the expected config location but this should be
> documented since, unlike NiFi, the instance is essentially useless if a
> config.yml isn't passed.
> [1]
> https://github.com/apache/nifi-minifi/blob/master/minifi-docker/dockerhub/Dockerfile
>
> [2] https://hub.docker.com/r/apache/nifi-minifi/tags/
> [3]
> https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/Dockerfile
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
