[
https://issues.apache.org/jira/browse/MINIFI-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522960#comment-16522960
]
ASF GitHub Bot commented on MINIFI-441:
---------------------------------------
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197976891
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
I know I can be a nitpicker sometimes on pull requests just to try to bring
stuff to attention to make sure it's what was intended. :) I have used `$VAR`
but I don't think I have ever used `${VAR}` in a Dockerfile.
> Update Dockerfile to '0.4.0' and better align with practices set in NiFi
> ------------------------------------------------------------------------
>
> Key: MINIFI-441
> URL: https://issues.apache.org/jira/browse/MINIFI-441
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.5.0
>
>
> The DockerHub Dockerfile[1] still lists 0.2.0 (even though dockerhub is up to
> 0.4.0[2]). Also, it doesn't appear to follow best practices like the NiFi
> Dockerfile[3] does, such as tailing the log file for exposing to the docker
> log.
> Lastly, there doesn't appear to be any documentation on the expected way to
> pass the bootstrap.conf and config.yml files. I'm assuming that this is done
> by creating a volume at the expected config location but this should be
> documented since, unlike NiFi, the instance is essentially useless if a
> config.yml isn't passed.
> [1]
> https://github.com/apache/nifi-minifi/blob/master/minifi-docker/dockerhub/Dockerfile
>
> [2] https://hub.docker.com/r/apache/nifi-minifi/tags/
> [3]
> https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/Dockerfile
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
