[ https://issues.apache.org/jira/browse/MINIFI-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522929#comment-16522929 ]
ASF GitHub Bot commented on MINIFI-441: --------------------------------------- Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/130#discussion_r197971051 --- Diff: minifi-docker/dockerhub/Dockerfile --- @@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME RUN apk --no-cache add curl +ADD sh/ ${MINIFI_BASE_DIR}/scripts/ --- End diff -- Either format is valid, and in this case, equivalent. From the [POSIX spec](http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02): > The simplest form for parameter expansion is: > > ${parameter} > > The value, if any, of parameter shall be substituted. > > The parameter name or symbol can be enclosed in braces, which are optional... If the parameter is not enclosed in braces, and is a name, the expansion shall use the longest valid name > Update Dockerfile to '0.4.0' and better align with practices set in NiFi > ------------------------------------------------------------------------ > > Key: MINIFI-441 > URL: https://issues.apache.org/jira/browse/MINIFI-441 > Project: Apache NiFi MiNiFi > Issue Type: Improvement > Reporter: Joseph Percivall > Assignee: Aldrin Piri > Priority: Major > Fix For: 0.5.0 > > > The DockerHub Dockerfile[1] still lists 0.2.0 (even though dockerhub is up to > 0.4.0[2]). Also, it doesn't appear to follow best practices like the NiFi > Dockerfile[3] does, such as tailing the log file for exposing to the docker > log. > Lastly, there doesn't appear to be any documentation on the expected way to > pass the bootstrap.conf and config.yml files. I'm assuming that this is done > by creating a volume at the expected config location but this should be > documented since, unlike NiFi, the instance is essentially useless if a > config.yml isn't passed. > [1] > https://github.com/apache/nifi-minifi/blob/master/minifi-docker/dockerhub/Dockerfile > > [2] https://hub.docker.com/r/apache/nifi-minifi/tags/ > [3] > https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/Dockerfile -- This message was sent by Atlassian JIRA (v7.6.3#76005)