Sarthak-Pandey commented on code in PR #20627:
URL: https://github.com/apache/nuttx/pull/20627#discussion_r4282037635


##########
net/tcp/tcp_send_buffered.c:
##########
@@ -1656,7 +1718,16 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR 
const void *buf,
        * conn->write_q
        */
 
+#ifdef CONFIG_NET_TCPURGDATA
+      if ((flags & MSG_OOB) != 0)
+        {
+          wrb->wb_urg = TCP_WBPKTLEN(wrb);

Review Comment:
   Good catch! I have updated psock_tcp_send() so that wrb->wb_urg is only 
marked on the final chunk (chunk_result == len) that completes the user buffer. 
Preceding chunks remain at wb_urg = 0. The same logic has also been aligned in 
tcp_send_unbuffered.c.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to