xiaoxiang781216 commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6493780722
> > @parthitce @ssekar15 please review #21110 provided by @zhangyu-duck. the drop of iLLD should be done step by step without breaking the current feature or remove the functionality. Since @zhangyu-duck already finish the remove of iLLD step by step, it's better to utilize his work and you focus on the new driver patch. > > I don't understand the reason to duplicate the efforts here. We are already handling this from our end and why duplicate? we start removing iLLD from the beginning of this year and sync the plan to Infineon in Q3. And the code run on EVB and real product with the full functionality (e.g. ZCU/ADD/XCD). > We are already handling the splits for the completed works. As I said many times, but I don't see the improvement in your PR(Please compare the change in this and #21110). The patch which changes the current code base must split into small and self-contained patch, instead removing the origin cod base and apply the refresh new one. Please note the current code base is running on the timing/life critical product. The change into the code base need be maintainable and reviewable. On the other hand, the fresh new code could be relaxed on the requirement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
