ssekar15 commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6462911537
@casaroli Thanks for your time for the review. > Commit [aac7762](https://github.com/apache/nuttx/commit/aac7762a90ccaf221a1f4afc963932e9f4b4164a) says the MPU and FPU sources stay in the build, but `tricore_mpu.c` no longer compiles (its CSFR numbers came from iLLD; #21042 adds them) and nothing selects `ARCH_HAVE_FPU` any more. > > Fix: squash [7acabfd](https://github.com/apache/nuttx/commit/7acabfdf2fef4a1601aaf90744d41668dfa95d2f) from #21042 into this PR and select `ARCH_HAVE_FPU` for `ARCH_CHIP_FAMILY_TC4X`. Based on preview review comments, idea is to exclude iLLD entirely and leaving iLLD dependnd driver(soon will be changed to native) are split into multiple PR as smaller chunk. does changing commit message "MPU and FPU sources stay in the build" & remove kconfig of FPU & MPU selection works? Also further splitting this PR for clock, GPIO, UART each. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
