yashmayya commented on code in PR #16552:
URL: https://github.com/apache/pinot/pull/16552#discussion_r2262350520
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/CountValueAggregator.java:
##########
@@ -36,7 +37,7 @@ public DataType getAggregatedValueType() {
}
@Override
- public Long getInitialAggregatedValue(Object rawValue) {
+ public Long getInitialAggregatedValue(@Nullable Object rawValue) {
Review Comment:
Should we be counting `null` values here?
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -124,6 +126,8 @@ private TableConfigUtils() {
// this is duplicate with KinesisConfig.STREAM_TYPE, while instead of use
KinesisConfig.STREAM_TYPE directly, we
// hardcode the value here to avoid pulling the entire pinot-kinesis module
as dependency.
private static final String KINESIS_STREAM_TYPE = "kinesis";
+
+ @Deprecated(since = "1.5.0", forRemoval = true)
Review Comment:
This isn't in the `spi` module so why can't we just directly remove it?
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/ValueAggregator.java:
##########
@@ -42,8 +43,10 @@ public interface ValueAggregator<R, A> {
/**
* Returns the initial aggregated value.
+ * <p>NOTE: rawValue can be null when the aggregator is used for ingestion
aggregation, and the column is not
+ * specified in the schema.
Review Comment:
Is this true even if null handling is enabled and we get actual `null`
values? Will those values always be substituted with the default null value for
the column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
