Jackie-Jiang commented on code in PR #16552:
URL: https://github.com/apache/pinot/pull/16552#discussion_r2263810345


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/ValueAggregator.java:
##########
@@ -42,8 +43,10 @@ public interface ValueAggregator<R, A> {
 
   /**
    * Returns the initial aggregated value.
+   * <p>NOTE: rawValue can be null when the aggregator is used for ingestion 
aggregation, and the column is not
+   * specified in the schema.

Review Comment:
   We get `null` values with/without null handling because the source column is 
not specified in the schema, and we don't know what is the default null value 
(or data type)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to