Jackie-Jiang commented on code in PR #16552:
URL: https://github.com/apache/pinot/pull/16552#discussion_r2263811970
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -124,6 +126,8 @@ private TableConfigUtils() {
// this is duplicate with KinesisConfig.STREAM_TYPE, while instead of use
KinesisConfig.STREAM_TYPE directly, we
// hardcode the value here to avoid pulling the entire pinot-kinesis module
as dependency.
private static final String KINESIS_STREAM_TYPE = "kinesis";
+
+ @Deprecated(since = "1.5.0", forRemoval = true)
Review Comment:
I'm not sure if any client/third party code is using it, but sure I think I
can remove it since the behavior is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
