Jackie-Jiang commented on code in PR #16552:
URL: https://github.com/apache/pinot/pull/16552#discussion_r2264078860
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/CountValueAggregator.java:
##########
@@ -36,7 +37,7 @@ public DataType getAggregatedValueType() {
}
@Override
- public Long getInitialAggregatedValue(Object rawValue) {
+ public Long getInitialAggregatedValue(@Nullable Object rawValue) {
Review Comment:
Decided to go with correct SQL semantic, where `null` is not counted if the
source is a column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
