Jackie-Jiang commented on code in PR #17601:
URL: https://github.com/apache/pinot/pull/17601#discussion_r2755734301
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/FileFormat.java:
##########
@@ -19,5 +19,5 @@
package org.apache.pinot.spi.data.readers;
public enum FileFormat {
- AVRO, GZIPPED_AVRO, CSV, JSON, PINOT, THRIFT, PARQUET, ORC, PROTO, OTHER
+ AVRO, GZIPPED_AVRO, CSV, JSON, PINOT, THRIFT, PARQUET, ORC, PROTO, OTHER,
PROTOBUF
Review Comment:
We don't need to add `PROTOBUF` given it is the same as `PROTO` and could
cause confusion
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -102,27 +104,44 @@ public class PluginManager {
}
};
- private static final Map<String, String>
INPUT_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
- new HashMap<String, String>() {
+ private static final Map<FileFormat, String>
FILE_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
Review Comment:
Given the lookup is always from `inputFormat`, we can keep the existing maps
as is, and just introduce one from `inputFormat (String)` to `FileFormat`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
