anshul98ks123 commented on code in PR #17601:
URL: https://github.com/apache/pinot/pull/17601#discussion_r2761754011
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -102,27 +104,44 @@ public class PluginManager {
}
};
- private static final Map<String, String>
INPUT_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
- new HashMap<String, String>() {
+ private static final Map<FileFormat, String>
FILE_FORMAT_TO_RECORD_READER_CLASS_NAME_MAP =
Review Comment:
Input in PluginManager is inputFormat and map exists from inputFormat
(string) to config. Here map entry is "protobuf"
whereas, in RecordReaderFactory, we have map from fileFormat to config. and
since existing protobuf enum is PROTO and not PROTOBUF, hence it causes
discrepancy
either we change "protobuf" to "proto" in PluginManager map
or introduce PROTOBUF enum to match "protobuf" of PluginManager map entry
Currently, we'll always have to make sure that string key entries in
PluginManager and fileFormat key entries in RecordReaderFactory always match in
value. -> To eliminate this, i was adding another map of string (inputFormat)
to fileFormat on your suggestion, to make both the file maps having the key as
fileFormat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
